feat(artifact_proxy): allow Flutter 3.44+ iOS USB dependency URLs#3787
Closed
bdero wants to merge 1 commit into
Closed
feat(artifact_proxy): allow Flutter 3.44+ iOS USB dependency URLs#3787bdero wants to merge 1 commit into
bdero wants to merge 1 commit into
Conversation
Flutter 3.44 (flutter/flutter#181539 and related) reorganized iOS USB artifact URLs from ios-usb-dependencies/<artifact>/<hash>/<artifact>.zip to ios-usb-dependencies/arm64_x86_64/<artifact>/<hash>/<artifact>.zip Upstream GCS serves both layouts. The proxy's allowlist only knew the pre-3.44 shape, so any 3.44+ customer's first iOS or Android build 404s during `flutter precache` against download.shorebird.dev. Add the 3.44+ patterns alongside the existing ones for each of the seven iOS USB dependencies. Pre-3.44 customers keep resolving against the old patterns unchanged.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Member
Author
|
Bundling into #3758 per release-driver request — same release-prereq concern, easier to land as one CL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flutter 3.44 reorganized iOS USB artifact URLs from
to
(see flutter/flutter#181539 and related). Upstream GCS serves both layouts indefinitely, but the proxy's allowlist only recognized the pre-3.44 shape. Without this change, every 3.44+ customer hits
404on their first iOS or Android build duringflutter precache(libimobiledevice, ios-deploy, etc.).Reproduction before the fix:
This adds an
arm64_x86_64/variant of each of the sevenios-usb-dependenciespatterns. The pre-3.44 patterns are preserved so customers pinned to older Flutter versions keep resolving against the old layout.Blocker for Flutter 3.44 release. Customers' first iOS/Android build on a 3.44 pin will 404 until this deploys.
Test plan
dart analyze lib/cleandart test(11/11 existing proxy tests still pass)curl -sI .../arm64_x86_64/libimobiledevice/<hash>/libimobiledevice.zipreturns 302 to storage.googleapis.comcurl -sI .../libimobiledevice/<hash>/libimobiledevice.zip(no arm64_x86_64 segment) still returns 302